sebas requested changes to this revision. sebas added a reviewer: sebas. This revision now requires changes to proceed.
INLINE COMMENTS applet/contents/ui/ListItemBase.qml:57 I'd turn this into more lines, using if's instead of the ternary, that would make it way easier to read. applet/contents/ui/ListItemBase.qml:65 Same here, make it more readable by spreading over multiple lines applet/contents/ui/main.qml:92 accolade on the same line as the function definition applet/contents/ui/main.qml:105 accolade on the same line as the function definition REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1443 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma: Design, Plasma, sebas Cc: sebas, colomar, plasma-devel
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
