----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127696/#review94728 -----------------------------------------------------------
there is one problem the icon colors don't fit the colors from the color scheme https://techbase.kde.org/Projects/Usability/HIG/Color icon red != danger red icon green != verdant green plasma blue is nearly equal with icon blue but the other colors don't fit. If you like I can check if the more fleshy new colors would work as well but I think not cause the idea of monochrome icons is to move the user interface to the background and let the content be more visible. - Andreas Kainz On April 20, 2016, 11:21 vorm., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127696/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 11:21 vorm.) > > > Review request for Plasma and Andreas Kainz. > > > Repository: plasma-framework > > > Description > ------- > > add named colors for positive (usually green) > neutral(usually yellow) negative(usually red) > foreground objects, such as text or parts of > svg icons/themes > > > Diffs > ----- > > autotests/data/plasma/desktoptheme/testtheme/colors e242dbb > autotests/themetest.cpp 3992246 > src/plasma/private/theme_p.cpp 1aaf021 > src/plasma/theme.h 271328c > > Diff: https://git.reviewboard.kde.org/r/127696/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel