-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127698/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

Currently, the "name" key is deleted from plasmarc when you select the default 
theme (breeze) in the desktop theme KCM.
This leads to unexpected behaviour: If you set e.g. oxygen as look&feel, and 
then set breeze as desktop theme, Plasma actually uses Air (the default desktop 
theme in the oxygen l&f) on next login instead of breeze. In other words, it is 
impossible to configure breeze as desktop theme when using a different 
look&feel as breeze.

This fixes the problem by removing the check whether the default theme is 
selected and always writes the "name" config key to plasmarc.


Diffs
-----

  src/plasma/private/theme_p.cpp 1aaf021 

Diff: https://git.reviewboard.kde.org/r/127698/diff/


Testing
-------

Set oxygen as look&feel, then set breeze as desktop theme. On next login, 
breeze is indeed used as desktop theme, without the patch Plasma will fall back 
to Air.

Changing themes or the look&feel still works the same otherwise.


Thanks,

Wolfgang Bauer

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to