----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127780/ -----------------------------------------------------------
(Updated April 29, 2016, 11:23 a.m.) Review request for Plasma. Repository: plasma-integration Description ------- The app config (KSharedConfig::openConfig()) is a mix of the app's settings and kdeglobals. Loading kdeglobals directly not only is a waste of resources, but breaks one of the key features of KConfig where a user can override global settings on a per app basis. What's worse is that KColorScheme when used directly does use the app config, so some apps give an inconsistent mix of results if you try and override settings. Diffs (updated) ----- src/platformtheme/kfontsettingsdata.cpp 94edfcbc4f11c5a6ae12cdeb17e4dcec3da5d360 src/platformtheme/khintssettings.cpp 2c4ab44366a3d2caac85a361c759aaf5a0a12fda Diff: https://git.reviewboard.kde.org/r/127780/diff/ Testing ------- Thanks, David Edmundson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
