broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rMILOU Milou.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This optimizes the sources model by avoiding model resets and cleaning up the 
code.

TEST PLAN
  KRunner feels a lot snappier. It does not fix the initial lag we get when 
ListView creates all the delegates but subsequent updates to the results should 
be noticeably faster. Unfortunately KRunner jumps around a bit sometimes when 
results come and go which was previously probably covered by it just blocking 
without rendering that.
  
  I didn't understand the way the results are stored in the model thorougly 
enough to make it a proper model with beginInsertRows/endInsertRows when new 
results are added, though.

REPOSITORY
  rMILOU Milou

REVISION DETAIL
  https://phabricator.kde.org/D1514

AFFECTED FILES
  lib/sourcesmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma
Cc: plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to