> On mei 8, 2016, 10:49 a.m., Mark Gaiser wrote: > > Modules/energy/batterymodel.cpp, lines 33-38 > > <https://git.reviewboard.kde.org/r/127864/diff/1/?file=464499#file464499line33> > > > > just: > > m_batteries = > > Solid::Device::listFromType(Solid::DeviceInterface::Battery); > > > > ? or am i missing something?
Note: tis has nothing to do with your change, but i just happen to notice that a list is being interated to be be put in a list again.. Seems a bit wastefull imho. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127864/#review95268 ----------------------------------------------------------- On mei 7, 2016, 8:22 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127864/ > ----------------------------------------------------------- > > (Updated mei 7, 2016, 8:22 p.m.) > > > Review request for Plasma. > > > Repository: kinfocenter > > > Description > ------- > > Remove second list storing duplicate data > > > Diffs > ----- > > Modules/energy/batterymodel.h c319d197b7cab1bed67151db65193bc5bcb24e2b > Modules/energy/batterymodel.cpp 7eade5498eda18ee0cfccddec70d5900c4eb2c96 > > Diff: https://git.reviewboard.kde.org/r/127864/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
