----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/#review95471 -----------------------------------------------------------
kcms/componentchooser/componentchooserbrowser.cpp (line 86) <https://git.reviewboard.kde.org/r/127918/#comment64722> That part fixes my bug, so it looks fine to me. But don't forget the other 5 or 6 places where similar code was introduced (in other files in this dir). kcms/componentchooser/componentchooserbrowser.cpp (line 100) <https://git.reviewboard.kde.org/r/127918/#comment64723> The variable name is confusing. This is not the kde4profile, but the one we just wrote, and which we want to copy over to the kde4 world, right? I guess it could be named "simpleConfig" since that's the only difference with the other KSharedConfig::Ptr from above ("profile"). - David Faure On May 14, 2016, 6:48 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127918/ > ----------------------------------------------------------- > > (Updated May 14, 2016, 6:48 p.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-desktop > > > Description > ------- > > Address David's issues in previous rr's regarding the code. > > > Diffs > ----- > > kcms/componentchooser/componentchooserbrowser.cpp 5795c2b > kcms/migrationlib/kdelibs4config.h bb2dca2 > > Diff: https://git.reviewboard.kde.org/r/127918/diff/ > > > Testing > ------- > > Default browser is correctly written in both ~/.kde4/share/config/kdeglobals > and ~/.config/kdeglobals > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel