----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127971/#review95628 -----------------------------------------------------------
+1 src/ktoolbar.cpp (line 815) <https://git.reviewboard.kde.org/r/127971/#comment64775> if you put this in Private::init() you'll only have to do it once. - David Edmundson On May 19, 2016, 9:26 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127971/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 9:26 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kxmlgui > > > Description > ------- > > While KXmlGui makes sure to prevent the user from hiding toolbars when not > allowed, right-clicking an empty space in a QMainWindow, such as the menu > bar, will yield a menu created by Qt, which knows nothing about Kiosk > restrictions, listing all toolbar toggle actions of this window. > > > Diffs > ----- > > autotests/ktoolbar_unittest.cpp d6c1e05 > src/ktoolbar.cpp 8fcb9cb > > Diff: https://git.reviewboard.kde.org/r/127971/diff/ > > > Testing > ------- > > Comes with a unittest. > > I can no longer hide the main toolbar in Dolphin or Gwenview when this action > is restricted by simply right-clicking the menu bar. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel