davidedmundson added a comment.
thanks INLINE COMMENTS > broulik wrote in Background.qml:36 > My gut feeling always makes me avoid QtGraphicalEffects where possible, ie. a > plain Rectangle; especially because the latter doesn't use a ShaderEffectItem > (2d renderer) I just go with the design. I could stick in a 1000x1 px png instead? > broulik wrote in Background.qml:49 > visible: image.status !== Image.Ready (or at least fix the second condition) I wanted to exclude .Loading. You're right I should fix it though > broulik wrote in Background.qml:54 > You don't position that thing according to screen geometry actually I do, it's the gradient that's wrong. > broulik wrote in Background.qml:56 > Not needed I think It is as PreserveAspectStretch overflows. I could make it a conditional on that though. Will be faster and self documenting. > broulik wrote in KeyboardButton.qml:23 > Use an Instantiator and use addMenuItem in the onObjectAdded handler (see > docs) Not sure I can. That's QtQml 2.2 - which is Qt5.6 I cursed a lot about having to go about this silly way > broulik wrote in UserDelegate.qml:144 > Isn't this Accessible.onPressAction? oh wow. ... it used to be this in QtQml1 - and this has been copied all the way from that LightDM code > broulik wrote in userModel.qml:28 > Schweinsteiger ;) ...that's even longer! REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1670 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: broulik, plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
