sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.


  looks good to me

INLINE COMMENTS

> integration.cpp:46
> +#include <qpa/qplatforminputcontext.h>
> +#include <qpa/qplatforminputcontextfactory_p.h>
> +#include <qpa/qwindowsysteminterface.h>

cross fingers?

> inputmethodstest.qml:82
> +    TextField {
> +        inputMethodHints: Qt.ImhTime
> +    }

DateTime and Terminal missing?

> virtualkeyboard.cpp:55
> +{
> +    // this is actually to late. Other processes are started before init,
> +    // so might miss the availability of text input

too late

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: sebas, mart, broulik, plasma-devel
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to