> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with > non-Linux platforms; considering libkscreen is a library used by components > (and also external ones, like the display configuration in LxQt), then it > makes sense to me making it portable. > > Making wayland mandatory in libkscreen (and also in other modules, like > plasma-integration, kwin, kscreenlocker) means killing outright any attempt > to make Plasma build on non-Linux platforms. Please reconsider this, thanks. > > Martin Gräßlin wrote: > which non-Linux platforms which we care about don't have Wayland? Before > making KWayland a mandatory dependency in Plasma we did check with distro > packagers. Everyone was fine with it.
At least to my reading of Wayland sources, to build the libraries you need features like signalfd and timerfd, which are non-POSIX and available only on Linux. Can you please point me to the discussion you had with distro packagers? - Pino ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128073/#review96120 ----------------------------------------------------------- On June 1, 2016, 8:10 a.m., Pino Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128073/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 8:10 a.m.) > > > Review request for Plasma, Solid, Daniel Vrátil, Martin Gräßlin, and > Sebastian Kügler. > > > Repository: libkscreen > > > Description > ------- > > Look for KF5Wayland as optional package, not building all the Wayland-related > code (backend, additions to tests, DPMS support in kscreen-doctor) if it is > not available. > > This allows libkscreen to build again on platforms without Wayland, such as > non-Linux or old Linux distros. > > > Diffs > ----- > > CMakeLists.txt 9c834d9500fa0b89764516464bd58e835671977b > autotests/CMakeLists.txt 2c8ee3d2021b1222072d6a1faafaff1b336d27e3 > backends/CMakeLists.txt 3563e138454edcc0c874237745123b09077d067c > src/doctor/CMakeLists.txt 7294d88af127a6604bc7e48e16342c93f152de8c > src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 > tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 > > Diff: https://git.reviewboard.kde.org/r/128073/diff/ > > > Testing > ------- > > Builds fine. > > > Thanks, > > Pino Toscano > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
