-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128097/
-----------------------------------------------------------

(Updated June 4, 2016, 9:53 p.m.)


Review request for KDE Software on Mac OS X, Plasma and Yichao Yu.


Changes
-------

For completeness sake, read the `onlyTicksInMenu` option from the GTk2 theme 
too.


Repository: qtcurve


Description
-------

This introduces an option (hidden for now) to adorn checked menu items with 
only a check mark rather than the same widget that is used for checkboxes or 
radio buttons (for sets of mutually exclusive menu items).

Initially I implemented this by simply skipping the widget "box" and drawing 
only the checkbox tick for both kinds of menu items (cf. 
https://bugs.kde.org/show_bug.cgi?id=363895). I then realised that this looks 
weird when the user uses a very tall or tiny font (or has a high DPI screen). 
Therefore the check is now generated using the UniCode `Check Mark` glyph (? 
cf. http://www.fileformat.info/info/unicode/char/2713/index.htm) rendered in 
the menu font (or `Apple Symbols`, on OS X).

A new member is introduced in the `Options` structure that controls this new 
behaviour. Its value is read from and written to the config file, but I have 
not yet implemented its UI control through the configuration interface. I'll 
want some guidance for that step.

I propose to make this the default behaviour on OS X, so that popup menus can 
be closer in appearance to the native menus from the toplevel menubar (those 
menus are not rendered through Qt, and use a single check mark too).

The GTk2 style already rendered checked menu items like this so I did not 
change anything there (and don't really plan to touch that code at all).


Diffs (updated)
-----

  gtk2/common/common.h cb0ec87 
  gtk2/common/config_file.cpp 96936e2 
  qt4/common/common.h 313db33 
  qt4/common/config_file.cpp c58ad1a 
  qt4/style/qtcurve.cpp 951ec1a 
  qt5/common/common.h bb103fd 
  qt5/common/config_file.cpp 362381a 
  qt5/style/qtcurve_api.cpp b8535da 
  qt5/style/qtcurve_primitive.cpp a8a2bed 

Diff: https://git.reviewboard.kde.org/r/128097/diff/


Testing
-------

On OS X 10.9 and Linux with Qt 4.8.7 and Qt 5.6.0 .


Thanks,

René J.V. Bertin

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to