davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.
much neater ++
INLINE COMMENTS
> shellcorona.cpp:345
> foreach(Plasma::Containment *containment, containments()) {
> - if (containment->formFactor() == Plasma::Types::Horizontal ||
> - containment->formFactor() == Plasma::Types::Vertical) {
> + if (containment->containmentType() !=
> Plasma::Types::CustomEmbeddedContainment && (containment->formFactor() ==
> Plasma::Types::Horizontal ||
> + containment->formFactor() == Plasma::Types::Vertical)) {
given the code beneath searches in m_panels and m_desktop white listing would
match better.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1791
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, davidedmundson
Cc: davidedmundson, plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
