graesslin marked 7 inline comments as done. graesslin added inline comments.
INLINE COMMENTS > broulik wrote in wallpaper_integration.cpp:33 > using namespace? I prefer having a huge namespace around the implementation of a class which is in the namespace. > broulik wrote in wallpaper_integration.cpp:40 > qmlRegisterType<...>(); ? It's used as a Q_PROPERTY, so qRegisterMetaType. At least that's what it complained about when I run it :-P > broulik wrote in wallpaper_integration.cpp:51 > emit configurationChanged, or, reuse the ConfigPropertyMap and reset it with > the new config (if that's possible, don't know the API) and make the > Q_PROPERTY CONSTANT actually it could be a CONSTANT property as it won't change in the runtime of kscreenlocker_greet. But what if the wallpaper binds to the change signal? Will that then raise a runtime error or is it allowed to do that? REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D1800 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc: broulik, plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
