----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128144/#review96340 -----------------------------------------------------------
\-1 Using Plasma theme in widgets-dialogs is a no-go. Proper fix would be: SystemPalette \{ id: syspal \} and then for the buttons and stuff: syspal.base and so on. Ideally the decoration QML bridge exposed the current colorscheme for the decoration- kcmkwin/kwindecoration/qml/Buttons.qml (line 47) <https://git.reviewboard.kde.org/r/128144/#comment65112> While at it, add spaces: 15 * layout.spacing kcmkwin/kwindecoration/qml/Buttons.qml (lines 216 - 217) <https://git.reviewboard.kde.org/r/128144/#comment65111> I fear this might lead to double spacing when Qt applies its widget-scaling and then Plasma does it ontop. kcmkwin/kwindecoration/qml/Buttons.qml (lines 221 - 224) <https://git.reviewboard.kde.org/r/128144/#comment65110> Why that change? - Kai Uwe Broulik On Juni 9, 2016, 11:30 nachm., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128144/ > ----------------------------------------------------------- > > (Updated Juni 9, 2016, 11:30 nachm.) > > > Review request for Plasma. > > > Repository: kwin > > > Description > ------- > > change the button area of the windowdecoration kcm to use the theme colors. > > > Diffs > ----- > > kcmkwin/kwindecoration/qml/Buttons.qml 2e64873 > > Diff: https://git.reviewboard.kde.org/r/128144/diff/ > > > Testing > ------- > > system settings -> Window Decoration -> Buttons tab used breeze dark color > scheme. > > > File Attachments > ---------------- > > dark theme bug > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/09/e0dd4fae-2a84-4b1e-a37d-f0ad75899050__bug.png > > > Thanks, > > Andreas Kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel