----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128108/#review96349 -----------------------------------------------------------
With the latest diff I get these runtime errors on the console: file:///home/koder/System/kf5-devel/share/plasma/plasmoids/org.kde.plasma.weather/contents/ui/TopPanel.qml:62:15: Unable to assign [undefined] to QString file:///home/koder/System/kf5-devel/share/plasma/plasmoids/org.kde.plasma.weather/contents/ui/TopPanel.qml:73:15: Unable to assign [undefined] to QString file:///home/koder/System/kf5-devel/share/plasma/plasmoids/org.kde.plasma.weather/contents/ui/TopPanel.qml:83:15: Unable to assign [undefined] to QString And accordingly broken does the toppanel look here. So please fix that. More, please remove the changes you added in the last version of this review request to the busy indicator and the high/low display again and provide them in a separate review request, those might need more discussion. The other design changes you did in the first version of this review request seemed fine to me, so let's get them in independently already (but only with a fixed version :) ). - Friedrich W. H. Kossebau On June 8, 2016, 10:25 p.m., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128108/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 10:25 p.m.) > > > Review request for Plasma and Friedrich W. H. Kossebau. > > > Repository: kdeplasma-addons > > > Description > ------- > > the scaling work now better and the pading between the single lines can be > smaler (If you make the applet higher you can also have the old line spacing) > > it's my first qml change, so ... > > on my todo, I'd like to change the powerd by weather.com text color so a > secondary gray (bring it a bit more to the background), but I don't know how. > > > Diffs > ----- > > applets/weather/package/contents/ui/FiveDaysView.qml 5023373 > applets/weather/package/contents/ui/TopPanel.qml 1821f16 > applets/weather/package/contents/ui/WeatherListView.qml c7b331e > applets/weather/package/contents/ui/configWeatherStation.qml 86ed521 > applets/weather/package/contents/ui/main.qml d490728 > > Diff: https://git.reviewboard.kde.org/r/128108/diff/ > > > Testing > ------- > > with breeze and breeze dark color scheme on two different pc's. the icons are > breeze weather icons (master) > > > File Attachments > ---------------- > > screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png > I hope I had fixed all open issues. I now have only one open issue I could > change the linkColor but I can't change the color when there is no link like > in noaa > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png > > > Thanks, > > Andreas Kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
