hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dfaure wrote in xwindowtasksmodel.cpp:662
> No clue, this "fixme" was already there, I'm only optimizing for speed. I'll
> let Eike reply to this.
64 is the value from the old lib. Improving this is on my todo, but it's not a
regression and I don't have time for it under the current schedule.
> xwindowtasksmodel.cpp:665
> + QPixmap pixmap;
> + const AppData &app = appData(window);
> + if (!app.icon.isNull()) {
Why not use the one from line 654?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1841
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, hein
Cc: broulik, plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
