mak added inline comments. INLINE COMMENTS
> mak wrote in plasma-desktop.metainfo.xml:3 > This should ideally be a reverse-domain-name, to fit the general style of > AppStream unique IDs. > So something like "org.kde.plasmashell" or "org.kde.plasma-desktop". > See > https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic oh, and if this is changed, renaming the metainfo file is a useful thing to do (-> "org.kde.plasmashell.metainfo.xml") > plasma-desktop.metainfo.xml:16 > + <caption>Plasma Desktop</caption> > + <image type="source" width="1470" > height="930">https://www.kde.org/workspaces/plasmadesktop/screenshots/general-desktop.png</image> > + </screenshot> FWIW, you can omit width and height here - the AppStream generators won't trust that information in metainfo files anyway and just fetch the screenshot and update the data accordingly. Also, the caption should probably be a bit more descriptive, e.g. "The Plasma desktop with a notes and clock widget." REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1844 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, #visual_design_and_promo, mak, #plasma, sebas Cc: bshah, sebas, plasma-devel
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
