mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
apart minor cosmetic issues is good to go.
do you have permissions to push on git?
INLINE COMMENTS
> kirigamiplugin.h:69
> + QUrl componentPath(const QString &fileName) const;
> + QString toFilePath(const QString &path) const {
> + return QLatin1Char(':') + path;
i would call them resolveFilePath/resolveFileUrl
also, implementation in the cpp with the { in new line
REPOSITORY
rKIRIGAMI Kirigami
REVISION DETAIL
https://phabricator.kde.org/D1860
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bearsh, mart
Cc: plasma-devel
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
