sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> keyboard_interface.cpp:186
>      if (wl_resource_get_version(d->resource) < 
> WL_KEYBOARD_REPEAT_INFO_SINCE_VERSION) {
>          // only supported since version 4
>          return;

sidenote: should it warn about a version mismatch to help debugging problems 
with clients, or would this be ineffective here or produce too much noise?

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  keyboard-unbound

REVISION DETAIL
  https://phabricator.kde.org/D2036

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, sebas
Cc: sebas, plasma-devel, jensreuterberg
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to