----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128316/#review96954 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On June 29, 2016, 10:40 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128316/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 10:40 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Even though QQuickItem only has a width and height accessor there is a > usable public setSize method. > > This gets rid of a lot of potential pointless re-evaluation as internal > geometry > is updated before widthChanged is emitted. > > > Diffs > ----- > > src/plasmaquick/appletquickitem.cpp > a9d044b1b50eace5d20441700eba3733c14b1ffd > src/plasmaquick/configview.cpp 5c2920bdc97643a353d47d6698a56f5d898b82e7 > src/scriptengines/qml/plasmoid/wallpaperinterface.cpp > adacbe19c3f306cf442850d45fed2933e48e6b4b > > Diff: https://git.reviewboard.kde.org/r/128316/diff/ > > > Testing > ------- > > Restarted Plasma, everything seems normal > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
