----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128402/#review97267 -----------------------------------------------------------
Nice feature, but the UI unnecessarily mixes two different interaction patterns: Checkboxes and drag&drop. What I'd prefer to do (and we should introduce that as a general paradigm for such things): Put a box "Hidden tabs" below the visualization of the active tabs and allow to add and remove via drag and drop. The visualization would be: --- Visible Tabs: [ ] [ ] [ ] (ideally visualized like the actual Plasmoid) "Hidden Tabs" [ ] [ ] Drag tabs between the boxes to show/hide them, or reorder the visible tabs by dragging. --- That way reaordering and show/hide would work in the same way, and the "Visible Tabs" box would always exactly represent reality. - Thomas Pfeiffer On July 9, 2016, 6:48 p.m., John Salatas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128402/ > ----------------------------------------------------------- > > (Updated July 9, 2016, 6:48 p.m.) > > > Review request for Plasma. > > > Bugs: 361210 > https://bugs.kde.org/show_bug.cgi?id=361210 > > > Repository: plasma-desktop > > > Description > ------- > > I'm using the Icons-Only Task Manager and it seems to me that the Favorites > tab in kickoff is somewhat redundant, as I have added launchers for all of my > favorites in the Icons-Only Task Manager. > So in this patch I'm introducing an option to hide any menu and also > according to bug 361210 to reorganize them. > > In the attached screenshot you can see > > 1) the configuration options: These are just the menu buttons than can be > rearranged via drag n drop and the also include a checkbox (checked: show it, > unchecked: hide it). > 2) The Kickoff menu with just 3 menu items (the other two are hidden). > > > Diffs > ----- > > applets/kickoff/package/contents/code/ButtonTools.js PRE-CREATION > applets/kickoff/package/contents/config/main.xml 2de73ba > applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION > applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b > applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c > applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 > applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128402/diff/ > > > Testing > ------- > > Tested in KDE Neon Developer Stable (as of July 8, 2016) > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png > > > Thanks, > > John Salatas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel