drosca requested changes to this revision.
drosca added a reviewer: drosca.
drosca added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> modulemanager.cpp:33
> + QObject(parent),
> + m_combineSinksConfig(new GConfItem(PA_GCONF_PATH_MODULES"/combine",
> this))
> +{
Can this be QStringLiteral?
> modulemanager.cpp:35
> +{
> + connect(m_combineSinksConfig, &GConfItem::subtreeChanged , this,
> &ModuleManager::combineSinksChanged);
> +}
remove space before comma: `&GConfItem::subtreeChanged ,`
> modulemanager.cpp:45
> +{
> + return m_combineSinksConfig->value("enabled").toBool();
> +}
QStringLiteral
> modulemanager.h:42
> +public:
> + ModuleManager(QObject *parent=0);
> + ~ModuleManager();
*parent = nullptr
> modulemanager.h:50
> +
> +protected:
> +private:
remove
REPOSITORY
rPLASMAPA Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D2073
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, drosca
Cc: drosca, broulik, plasma-devel, jensreuterberg, abetts, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
