----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128519/#review97823 -----------------------------------------------------------
startkde/startkde.cmake (line 287) <https://git.reviewboard.kde.org/r/128519/#comment65919> In this branch, not setting the env var would amount to the same, since that's the default value. This would also allow to just keep the value as it is, e.g. if the user sets it in the script that calls startkde. This was also Rex Dieter's opinion in the bug description for https://bugs.kde.org/show_bug.cgi?id=332107 (the bug is fixed, but still, I would argue with not messing with an env var if we don't need to) - David Faure On July 25, 2016, 10:18 a.m., Nicolas Lécureuil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128519/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 10:18 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > ------- > > in default plasma, XDG_DATA_DIRS is set to > /usr/usr/share:/usr/share:/usr/share/local , this patch tend to fix this > issue and try to remove dupplicate /usr/share:/usr/share > > > Diffs > ----- > > startkde/startkde.cmake b320234 > > Diff: https://git.reviewboard.kde.org/r/128519/diff/ > > > Testing > ------- > > applied the patch and start plasma. > > > Thanks, > > Nicolas Lécureuil > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
