mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in shellcorona.cpp:511
> > can we have kconf_update that are guarantee to run before plasmashell is
> > started?
>
> Good question.
>
> kconf_update also monitors for new scripts at runtime, which is another bug
> waiting to happen.
>
> We might need to have some sort of:
>
> if (exists(plasma-shell-appletsrc) {
>
> move(plasma-shell-appletsrc , plasma-shell-lnf-appletsrc)
>
> }
this in the conf update?
> davidedmundson wrote in shellcorona.cpp:720
> Might be nice, but that doesn't solve the thing that's the problem.
>
> You can't just randomly delete things owned by some other object. Knowing
> which objects owns what is a core part of good design.
>
> From what I can see:
>
> - Applet owns the DeclarativeAppletScript (member var script)
> - DeclarativeAppletScript owns the AppletInterface (AppletScript set as
> parent)
>
> delete the applet (which is literally the next line) and you delete this
> anyway.
>
> If this solves a problem, you're solving it in the wrong place.
iirc i did that because if it was done automatically, some appletremoved
signals were triggered causing loss of some configuration.
I'll see if i can find the root cause for that
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2345
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, davidedmundson, #plasma
Cc: davidedmundson, ivan, plasma-devel, ali-mohamed, jensreuterberg, abetts,
sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
