----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98101 -----------------------------------------------------------
I got to the signal and stopped reading. This is a trillion times better. This looks fine. src/scriptengines/qml/plasmoid/containmentinterface.cpp (line 248) <https://git.reviewboard.kde.org/r/128597/#comment66072> surely this needs a if width > 0 in here? Also QSize has a concept of isNull() if width and height are 0. This would also allow us to use the default constructor rather than passing -1. - David Edmundson On Aug. 4, 2016, 11:44 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128597/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 11:44 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > in the addapplet signal, support size paramenters as well, to specify a full > geometry where you want the plasmoid. > > > Diffs > ----- > > src/scriptengines/qml/plasmoid/containmentinterface.h 8236105 > src/scriptengines/qml/plasmoid/containmentinterface.cpp c390ad1 > > Diff: https://git.reviewboard.kde.org/r/128597/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
