broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land.
There's still something off when I drag a bottom favorite to the top if often ends up in the wrong place or doesn't move at all. This is with and without this patch, so looks good to me. For 5.8 where I reworked the drag-drop stuff I'll look if this is still the case and fix it. :) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, bshah, #plasma, broulik Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
