mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in shellcorona.cpp:383
> No!!!!
> 
> you need to loop through containments() rather than the views
> (same for panel section)
> 
> Otherwise:
> 
> - you're only saving the currently plugged in screens.
> - this won't save the configuration for any applets in a system tray.
> 
> and when you do do the system tray you're going to have a huge problem:
> system tray writes out SystrayContainmentId... you aren't going to know what 
> that is.

can't for panels, as their geometry is saved in the view as it should be, 
because they have a separate geometry setting per screen.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Reply via email to