----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review98219 -----------------------------------------------------------
Ship it! Ship It! - Martin Gräßlin On July 21, 2016, 3:37 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126131/ > ----------------------------------------------------------- > > (Updated July 21, 2016, 3:37 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > The QSGTextures are created with > > window()->createTextureFromId(m_texture, QSize(w,h), > QuickWindow::TextureOwnsGLTexture)); > > this means we don't want to be deleting textures ourselves too, it will > be deleted when we delete the QSGTexture, which is a scoped pointer > inside our QSGNode. > > BUG: 355644 > REVIEW: > > > Diffs > ----- > > src/declarativeimports/core/windowthumbnail.cpp > 6c46789b13411fe311c4d3fb60c690abd966cc38 > > Diff: https://git.reviewboard.kde.org/r/126131/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >