----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/#review98254 -----------------------------------------------------------
Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 10, 2016, 1:03 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128640/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 1:03 a.m.) > > > Review request for KDE Frameworks, Plasma and David Faure. > > > Repository: plasma-framework > > > Description > ------- > > Commit bb70febdbe397b617e5c41aff5494fdbc185fa88 changed the slot for > adding createApplet, turning the final argument from QPoint to QRect. > > If the rectangle size is nothing, it acts like the original code. > > Despite this being private API (ish) there is a hacks in plasma- > workspace that call methods on the view via QMetaObject invoke. This > obviously fails. As we need compatibility for Plasma/5.7 and earlier a > compatibility slot needs to stay. > > > *THIS NEEDS BACKPORTING TO 5.25* > > > Diffs > ----- > > src/scriptengines/qml/plasmoid/containmentinterface.h > c058f8358b4aa123749959a3de5b0667d7a1fecc > src/scriptengines/qml/plasmoid/containmentinterface.cpp > 4efc1e109bbab8ef43b686be25574ed5bd66d9ce > > Diff: https://git.reviewboard.kde.org/r/128640/diff/ > > > Testing > ------- > > Before: alternatives context menu on the desktop just deleted the applet > Now: works > > > Thanks, > > David Edmundson > >