davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
Seems good.
INLINE COMMENTS
> AppletConfiguration.qml:219
> +
> + Column {
> + id: categories
If you make this this a ColumnLayout the layout's implicitWidth will be the
size of the largest item, simplifiying line 167-176 to be a single line.
Your loop works, so only change it if you want to.
> ConfigCategoryDelegate.qml:87
> + opacity: { // try to match Breeze style hover handling
> + var active = categoriesScroll.activeFocus && Window.active
> + if (current) {
get rid of the && Window.active
it does nothing.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2398
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma:_design, andreaska, #plasma, davidedmundson
Cc: davidedmundson, andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas
