mart added inline comments.
INLINE COMMENTS
> KeyboardButton.qml:13
>
> - text: instantiator.objectAt(currentIndex).shortName
> + text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Keyboard Layout:
> %1", instantiator.objectAt(currentIndex).shortName)
> implicitWidth: minimumWidth
is this domain valid for sddm as well?
> UserDelegate.qml:85
>
> - //if copying into another project don't forget to * qt_Opacity. It's
> just unused here
> - //and connect themeChanged to update()
> + //if copying into another project don't forget to connect
> themeChanged to update()
> + //but in SDDM that's a bit pointless
this version you have is probably is significantly faster (and in this case
i'll shut up :p)
but wouldn't look cleaner to have something along the lines:
layer.enabled: true
layer.effect: OpacityMask {
maskSource: Rectangle {
anchors.centerIn: parent
width: imageWrapper.width
height: width
radius: width/2
}
}
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2399
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
