broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY When simultaneously fading two items (one from fully opaque to transparent and the other one vice-versa) you can briefly see the black background through the images leading to an ugly flicker. By only doing this when the old image could be seen (when the new one has a smaller size) we avoid this in the common case of full-size wallpapers. TEST PLAN Added a large and tiny wallpaper, randomly switched between them, also played around with various scale modes. It no longer flickers everytime the wallpaper is changed. This obviously breaks (as in you can see the old image which then suddenly disapperas once the animation finishes) images with alpha channel but I don't think we actively support/encourge that? It's just a corner-case anyway imho. I noticed that because kscreenlocker greeter sets the image size after the wallpaper has loaded causing it to reload (source size changed) and this flickered when the lock screen showed up. This issue needs to be addressed separately but this patch still gives us a more polished look, especially when using a slideshow wallpaper. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2484 AFFECTED FILES wallpapers/image/imagepackage/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
