> On Aug. 19, 2016, 8:23 a.m., Martin Gräßlin wrote:
> > I'm not happy with the QWebEngineView as that's going to crash on Wayland. 
> > Every application using QWebEngine needs to be on xcb unfortunately. So 
> > that means that we cannot really use anything of QWebEngine in Plasma 
> > (which is supposed to work on Wayland)
> 
> Martin Gräßlin wrote:
>     Just tried a bit, here is IRC log:
>     [10:07] <mgraesslin_yoga> notmart: 
>     [10:07] <mgraesslin_yoga> [0819/100656:ERROR:gl_surface_qt.cpp(187)] 
> GLContextHelper::getXConfig() failed.
>     [10:07] <mgraesslin_yoga> Segmentation fault (core dumped)
>     [10:08] <notmart> woha
>     [10:08] <mgraesslin_yoga> notmart: that was the demobrowser
>     [10:08] <mgraesslin_yoga> same with minimal
>     [10:08] <notmart> the qml one as well?
>     [10:08] <notmart> (which defies a bit the point of qml bindings for the 
> thing)
>     [10:08] <mgraesslin_yoga> quicknanobrowser?
>     [10:09] <notmart> that or angelfish
>     [10:09] <mgraesslin_yoga> sec, has missing deps
>     [10:10] <mgraesslin_yoga> notmart: yep, also asserts and prints the 
> getXConfig warning
>     [10:10] <mgraesslin_yoga> notmart: adding --platform xcb makes it start, 
> but that's of course no option
>     [10:11] <notmart> yep, not for stuff inside plasma for sure

now reported upstream: https://bugreports.qt.io/browse/QTBUG-55384


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98490
-----------------------------------------------------------


On Aug. 18, 2016, 2:47 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2016, 2:47 p.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
>     http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org"; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> -------
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Reply via email to