mart added a comment.
code looks nice.
you maybe want to add a screenshot, for the final go from vdg
INLINE COMMENTS
> KeyboardLayoutButton.qml:37
> +
> + menu: QQC.Menu {
> + id: keyboardMenu
does a qmenu work on top the special lockscreen window?
> Login.qml:25
> + //but more importantly it works round a Qt bug that can trigger if
> the app is closed with a TextField focussed
> + //DAVE REPORT THE FRICKING THING AND PUT A LINK
> + loginButton.forceActiveFocus();
you maybe want to "report the friking thing and put a link" before pushing :)
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2523
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
