----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/#review98639 -----------------------------------------------------------
src/plasma/private/applet_p.cpp (line 241) <https://git.reviewboard.kde.org/r/128754/#comment66446> I think always emitting is error prone. You can emitting twice even 3 times. Same below. - Anthony Fieroni On Авг. 25, 2016, 2:48 след обяд, David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128754/ > ----------------------------------------------------------- > > (Updated Авг. 25, 2016, 2:48 след обяд) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This allows a custom applet to do cleanup (like the system tray, to > delete the inner containment) > > Extra guard in the system tray finding a corona. > > > Diffs > ----- > > src/plasma/containment.cpp ec2d5c22504206c9fca55a7c4aba56bdb6065818 > src/plasma/private/applet_p.h 7a7dc3d4bd4a2d006d21ead4243667332dac4264 > src/plasma/private/applet_p.cpp b0f9edb56b6e85e85080945bf8038cd70b7698af > > Diff: https://git.reviewboard.kde.org/r/128754/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
