broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY The logic for scrolling a focus item into view was mostly meant for keyboard-navigating through a list of CheckBoxes. However, an inner ScrollView - like plasma-pa has in its config dialog - can also gain activeFocus. This had us try to scroll the ScrollView into view, usually scrolling away other view contents. With the added logic we only try to scroll if the control is barely visible at the bottom but not if significant portions of it are already visible. TEST PLAN I can still tab through task manager settings and have the view scroll properly. Switching tabs in plasma-pa applet config dialog no longer scrolls the tabs out of view. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2585 AFFECTED FILES desktoppackage/contents/configuration/AppletConfiguration.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
