> On Aug. 26, 2016, 1:06 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qmenu.cpp, line 91 > > <https://git.reviewboard.kde.org/r/128767/diff/1/?file=475430#file475430line91> > > > > and these ones?
Not called by qmlpluginscanner, but yeah if you prefer I can add if()s in all methods. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128767/#review98691 ----------------------------------------------------------- On Aug. 26, 2016, 7:05 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128767/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 7:05 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This happens when QtCreator launches qmlplugindump. > Testcase: qmlplugindump -nonrelocatable org.kde.analitza 1.1 > or qmlplugindump -nonrelocatable org.kde.okular 2.0 > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qmenu.cpp > b7037da2ade97ce3632efa8f77e2a3f16e54107e > > Diff: https://git.reviewboard.kde.org/r/128767/diff/ > > > Testing > ------- > > see description > > Lots of warnings still, but at least it doesn't crash. > > QObject: Cannot create children for a parent that is in a different thread. > (Parent is QGuiApplication(0x7ffd16f340c0), parent's thread is > QThread(0x14af560), current thread is QThread(0x14e4240) > Could not find any platform plugin > > > Thanks, > > David Faure > >