mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:1
> +add_definitions(-DTRANSLATION_DOMAIN=\"plasmashellprivateplugin\")
> +

unrelated?

> CMakeLists.txt:20
>      KF5::ConfigGui
> +    KF5::I18n
>      PW::KWorkspace

in same commit as -DTRANSLATION_DOMAIN?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2594

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Reply via email to