----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128890/ -----------------------------------------------------------
Review request for KDE Frameworks, Plasma and Boudhayan Gupta. Repository: baloo Description ------- lmdb itself is thread safe (e.g. you can use the same env in multiple threads). Unfortunately, the Baloo::Database itself not, as open() might race against other open calls (we have one unique db object in baloo). => add non-recursive mutex (recursive mutex not needed, one just must avoid to call isOpen() or path() inside open, that is done, else no unit test works). Diffs ----- src/engine/database.h e3bb175 src/engine/database.cpp ec7ae2e Diff: https://git.reviewboard.kde.org/r/128890/diff/ Testing ------- Unit tests still work. Thanks, Christoph Cullmann