> On Sept. 11, 2016, 9:35 p.m., Vishesh Handa wrote: > > This is awesome. Ship it. > > Christoph Cullmann wrote: > Lets hope it is awesome correct.
:D - Milian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99115 ----------------------------------------------------------- On Sept. 11, 2016, 9:39 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128892/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2016, 9:39 p.m.) > > > Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > At the moment, any application that uses baloo can corrupt the db. > Now, only the things that need to write to it open it with read-write. > This only works as long as the library exposes only read-only things like > Query/... > > > Diffs > ----- > > src/engine/database.h 6ccb2a5 > src/engine/database.cpp 6a433c7 > src/file/extractor/app.cpp 0ca7276 > src/lib/file.cpp cbbc912 > src/lib/searchstore.cpp 060a4fd > src/lib/taglistjob.cpp 76ac8ff > src/qml/experimental/monitor.cpp 11c06ae > src/tools/balooctl/main.cpp 2a6b175 > src/tools/balooctl/statuscommand.cpp 1a56c64 > src/tools/balooshow/main.cpp f45f2e0 > > Diff: https://git.reviewboard.kde.org/r/128892/diff/ > > > Testing > ------- > > Unit tests still work, balooctl seems to do something. > > > Thanks, > > Christoph Cullmann > >