----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128899/#review99206 -----------------------------------------------------------
Ship it! this is the same patch that appeared in phabricator as well, right? - Marco Martin On Sept. 14, 2016, 10:11 a.m., Jason A. Donenfeld wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128899/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2016, 10:11 a.m.) > > > Review request for Plasma, David Edmundson and Marco Martin. > > > Repository: plasma-desktop > > > Description > ------- > > First we remove the fallback code for a version of Xcursor that > corresponds with an X server KDE doesn't even support any more. > > Then we reverse the order of tilde expansion and deduplication, which > before was essentially incorrect. > > Next we do deduplication properly, using Qt's removeDuplicates function. > > Finally we replace the ugly regex with the helper function in > kcoreextras via std::transform. > > This work here reflects the recent review and discussion that went into > the nearly identical code in kde-gtk-kcm. > > > Diffs > ----- > > kcms/cursortheme/xcursor/thememodel.cpp > e0cb420b7787261d9b5a54b9c0d448d8dd65a988 > > Diff: https://git.reviewboard.kde.org/r/128899/diff/ > > > Testing > ------- > > > Thanks, > > Jason A. Donenfeld > >