> On 十月 4, 2016, 3:56 p.m., Eike Hein wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > > language code so they can also be used by kimpanel (which in turn can use > > fcitx or ibus or scim)? Do you really need different icons for each IME > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > > Yunhe Guo wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can also be used by kimpanel (which in turn can use > fcitx or ibus or scim)? > > Having icons for specific fcitx plugins upstream seems like bad > layering. > > I just use the same icon name in original Fcitx icons. These icons were > tested with Fcitx classic UI, not Kimpanel. But as far as I know, **kimpanel > is just a part of Fcitx project**. So here is no "fcitx plugin" problem. What > icons that Fcitx uses is always what kimpanel uses. So these icons will > provide same support to ibus and scim if they use kimpanel as UI (by default, > not). > > > Do you really need different icons for each IME engine instead of just > per language? > > Those Chinese IMEs are totally different. It is impossible to use only > one icon for all without confusing users. > > Xuetian Weng wrote: > Can you separate the request into two different ones? input-keyboard > addition is quite generic. while the im icon is input method specific.
Now input-keyboard in another patch https://git.reviewboard.kde.org/r/129098/ - Yunhe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review99774 ----------------------------------------------------------- On 十月 4, 2016, 4:38 p.m., Yunhe Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ > ----------------------------------------------------------- > > (Updated 十月 4, 2016, 4:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This patch adds icons for Fcitx system tray icon. Fcitx is the default input > method framework in most Chinese GNU/Linux desktop system. These icons will > make Fcitx looks better in system tray. > > Icons included: > > input.svgz > > - input-keyboard > > fcitx.svgz > > - fcitx > - fcitx-kbd > - fcitx-pinyin > - fcitx-shuangpin > - fcitx-wubi > - fcitx-pinyin-libpinyin > - fcitx-shuangpin-libpinyin > - fcitx-bopomofo > - fcitx-sunpinyin > - fcitx-googlepinyin > - fcitx-emoji > > > Diffs > ----- > > src/desktoptheme/breeze/icons/fcitx.svgz PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129091/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Spectacle.Et8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png > Spectacle.AD8101.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png > > > Thanks, > > Yunhe Guo > >
