antlarr created this revision. antlarr added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY Removes preferred definition so a new wallpaper is selected. Also, just in case, check for division by 0. When the screen resolution changes, a new wallpaper has to be chosen but this is not happening unless we remove the preferred definition. This depends on https://git.reviewboard.kde.org/r/129118/ to be accepted. TEST PLAN I ran plasmashell with the default opensuse wallpaper (a green bulb) while changing the screen resolution between 1024x768 and 1280x720. With this and the kpackage patch above, a different background image is selected correctly with the correct aspect ratio. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2981 AFFECTED FILES wallpapers/image/image.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas