graesslin created this revision. graesslin added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY Hit a crash there, this change prevents it: Thread 1 "plasmashell" received signal SIGSEGV, Segmentation fault. QObject::setProperty (this=0x0, name=0x7fff2dd11a68 "initialPositionSet", value=...) at kernel/qobject.cpp:3849 3849 const QMetaObject* meta = metaObject(); (gdb) bt #0 QObject::setProperty (this=0x0, name=0x7fff2dd11a68 "initialPositionSet", value=...) at kernel/qobject.cpp:3849 #1 0x00007fff2dd09d0b in NotificationsHelper::addNotificationPopup(QObject*) () from /opt/kf5/lib/x86_64-linux-gnu/qml/org/kde/plasma/private/notifications/libnotificationshelperplugin.so #2 0x00007fff2dd1106d in NotificationsHelper::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) () from /opt/kf5/lib/x86_64-linux-gnu/qml/org/kde/plasma/private/notifications/libnotificationshelperplugin.so #3 0x00007fff2dd112a3 in NotificationsHelper::qt_metacall(QMetaObject::Call, int, void**) () from /opt/kf5/lib/x86_64-linux-gnu/qml/org/kde/plasma/private/notifications/libnotificationshelperplugin.so #4 0x00007ffff4eddc99 in QQmlObjectOrGadget::metacall (this=this@entry=0x7fffffff3bd0, type=type@entry=QMetaObject::InvokeMetaMethod, index=<optimized out>, index@entry=11, argv=<optimized out>) at qml/qqmlpropertycache.cpp:1547 #5 0x00007ffff4e70028 in CallMethod (object=..., index=<optimized out>, returnType=returnType@entry=43, argCount=<optimized out>, argTypes=<optimized out>, engine=engine@entry=0x849cf0, callArgs=<optimized out>) at jsruntime/qv4qobjectwrapper.cpp:1137 #6 0x00007ffff4e71478 in CallPrecise (object=..., data=..., engine=engine@entry=0x849cf0, callArgs=callArgs@entry=0x7fffdc230558) at jsruntime/qv4qobjectwrapper.cpp:1388 #7 0x00007ffff4e71ced in QV4::QObjectMethod::callInternal (this=<optimized out>, callData=<optimized out>) at jsruntime/qv4qobjectwrapper.cpp:1871 #8 0x00007ffff4e86d21 in QV4::Object::call (d=0x7fffdc230558, this=<optimized out>) at jsruntime/qv4object_p.h:332 #9 QV4::Runtime::callProperty (engine=0x849cf0, nameIndex=<optimized out>, callData=0x7fffdc230558) at jsruntime/qv4runtime.cpp:1030 #10 0x00007fff2dce8152 in ?? () #11 0x3a3a646e616c7961 in ?? () #12 0x3a3a746e65696c43 in ?? () #13 0x0000000000000000 in ?? () REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH notification-add-popup-null REVISION DETAIL https://phabricator.kde.org/D3051 AFFECTED FILES applets/notifications/plugin/notificationshelper.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, broulik Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas