graesslin added inline comments. INLINE COMMENTS
> usta wrote in kwaylandintegration.cpp:57 > #include <QCoreApplication> removed and #include <QGuiApplication added so > isn't this also should be change ? no? We try to not change unrelated code. The include of QGuiApplication is due to the usage of QGuiApplication::topLevelWindows. For this code it doesn't make any difference whether it's QCoreApplication or QGuiApplication. So there is no need to change it. The code is correct and a change would clutter up the commit. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH color-scheme-wayland REVISION DETAIL https://phabricator.kde.org/D3046 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, sebas Cc: usta, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
