----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129255/#review100290 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Oct. 24, 2016, 9:27 p.m., Massimiliano Torromeo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129255/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 9:27 p.m.) > > > Review request for Plasma. > > > Bugs: 341305 > https://bugs.kde.org/show_bug.cgi?id=341305 > > > Repository: kio-extras > > > Description > ------- > > The parameter "--version" stopped working since unrar 5.2 which was > released almost 2 years ago. > With this change this now becomes the minimum version required but > every distribution that is going to include a version of KDE with > this commit has probably been using unrar > 5.2 for quite a while > so I don't think there is any need to provide a fallback. > > This fixes bugs 367626 and 341305 > > > Diffs > ----- > > thumbnail/comiccreator.cpp 4ec0db8c6953e2d9983e4a9d7f542b27404175e4 > > Diff: https://git.reviewboard.kde.org/r/129255/diff/ > > > Testing > ------- > > Verified that the previously missing thumbnails for cbr files are now being > correctly generated. > > > Thanks, > > Massimiliano Torromeo > >