mart added a comment.
code looks good.
I tested the urls, annotated inline those that work and those that don't.
Unfortunately there are still two that don't, in flickr, where a no longer
valid api key is used and the wikipedia one.
INLINE COMMENTS
> apodprovider.cpp:83
> {
> - KUrl url( QLatin1String( "http://antwrp.gsfc.nasa.gov/apod/"; ) );
> + QUrl url( QLatin1String( "http://antwrp.gsfc.nasa.gov/apod/"; ) );
> KIO::StoredTransferJob *job = KIO::storedGet( url, KIO::NoReload,
> KIO::HideProgressInfo );
works, +1
> epodprovider.cpp:82
> {
> - KUrl url( QLatin1String( "http://epod.usra.edu/blog/"; ) );
> + QUrl url( QLatin1String( "http://epod.usra.edu/blog/"; ) );
> KIO::StoredTransferJob *job = KIO::storedGet( url, KIO::NoReload,
> KIO::HideProgressInfo );
this works, +1
> flickrprovider.cpp:81
>
> - KUrl url( QLatin1String(
> "http://api.flickr.com/services/rest/?api_key=a902f4e74cf1e7bce231742d8ffb46b4&method=flickr.interestingness.getList&date=";
> ) + mActualDate.toString( Qt::ISODate) );
> + QUrl url( QLatin1String(
> "https://api.flickr.com/services/rest/?api_key=11829a470557ad8e10b02e80afacb3af&method=flickr.interestingness.getList&date=";
> ) + mActualDate.toString( Qt::ISODate) );
> KIO::StoredTransferJob *pageJob =
> KIO::storedGet(url, KIO::NoReload, KIO::HideProgressInfo);
this one is valid, same api key should be used in the other queries
> flickrprovider.cpp:129
> + QUrl url(QLatin1String(
> +
> "https://api.flickr.com/services/rest/?api_key=a902f4e74cf1e7bce231742d8ffb46b4&method=flickr.interestingness.getList&date=";
> ) + date().toString( Qt::ISODate ) );
says "key has expired",
should have 11829a470557ad8e10b02e80afacb3af instead?
> natgeoprovider.cpp:96
> {
> - const QUrl url( QLatin1String(
> "http://photography.nationalgeographic.com/photography/photo-of-the-day"; ) );
> + const QUrl url( QLatin1String(
> "https://www.nationalgeographic.com/photography/photo-of-the-day"; ) );
> connect( d->mPage, SIGNAL(loadFinished(bool)), this,
> SLOT(pageRequestFinished(bool)) );
works, +1
> noaaprovider.cpp:95
> {
> - const QUrl url( QLatin1String(
> "http://photography.nationalgeographic.com/photography/photo-of-the-day"; ) );
> + QUrl url( QLatin1String( "http://www.nnvl.noaa.gov/imageoftheday.php"; )
> );
> connect( d->mPage, SIGNAL(loadFinished(bool)), this,
> SLOT(pageRequestFinished(bool)) );
this one works, +1
> wcpotdprovider.cpp:54
>
> - KUrl picUrl( QLatin1String(
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"; ) );
> KIO::StoredTransferJob *imageJob = KIO::storedGet( picUrl, KIO::NoReload,
> KIO::HideProgressInfo );
> + QUrl picUrl( QLatin1String(
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"; ) );
> KIO::StoredTransferJob *imageJob = KIO::storedGet( picUrl, KIO::NoReload,
> KIO::HideProgressInfo );
> mParent->connect( imageJob, SIGNAL(finished(KJob*)),
> SLOT(imageRequestFinished(KJob*)) );
other copy of invalid url
> wcpotdprovider.cpp:73
> {
> - KUrl url( QLatin1String(
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"; ));
> + QUrl url( QLatin1String(
> "http://tools.wikimedia.de/~daniel/potd/potd.php/commons/800x600"; ));
>
this url doesn't seem to be valid anymore
maybe should web-scrape
https://en.wikipedia.org/wiki/Wikipedia:Wikimedia_Commons/POTD ?
(don't know if there is a way to obtain directly the image)
REPOSITORY
rKDEPLASMAADDONS Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D3183
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: xuetianweng, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
