2016-04-08 16:42 GMT+03:00 Marco Martin <notm...@gmail.com>: > On Friday 08 April 2016 01:54:07 Alexander Potashev wrote: >> 75. Translations for powerdown/suspend/... actions should be shared >> between all powerdevil*config.po files, they are currently duplicated, >> making them hard to maintain. Please share the code between the >> respective configuration dialogs. >> powerdevilactivitiesconfig.po-60-#: activitywidget.cpp:98 >> powerdevilactivitiesconfig.po-61-msgid "Suspend" > > what do you mean share code exatly? same term?
Marco, Look closely at 1. GeneralPage::fillUi() in powerdevil/kcmodule/global/GeneralPage.cpp and 2. ActivityWidget::load() in powerdevil/kcmodule/activities/activitywidget.cpp. Both of these methods populate a combobox with the same items (Suspend, Hibernate, Shut down), that code can be deduplicated. -- Alexander Potashev
