graesslin added a comment.
In https://phabricator.kde.org/D3240#60265, @hpereiradacosta wrote: > In https://phabricator.kde.org/D3240#60257, @hpereiradacosta wrote: > > > Did you test whether unpolish is actually called ? Last time I tried, it was not, at least not always. (depending on whether you run a QApplication, KApplication, etc.) > > This is what led to the mess of destroying the singleton style in the plugin helper, which in turn created other crashes, and which was removed aferwards. > > This all story of QStyle dinitialization is a mess ... > > > Ah > sorry. > I misread the fact that you actually make sure that kwin calls the unpolish. For the general case you are right. Unpolish is only called from QApplication::setStyle when the old style gets destroyed. On Application tear-down it's not called. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3240 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, broulik, hpereiradacosta Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
